Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python35: remove #95305

Merged
merged 2 commits into from
Aug 15, 2020
Merged

python35: remove #95305

merged 2 commits into from
Aug 15, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 13, 2020

Motivation for this change

It's EOL soon, and should be removed before 20.09

closes: #95272

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-95305/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages removed:
python3 (†3.5.9) python3 (†3.5.9)

Nothing changed
https://github.com/NixOS/nixpkgs/pull/95305
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-95305/shell.nix

@jonringer jonringer requested a review from FRidh as a code owner August 13, 2020 04:58
@ofborg ofborg bot added 6.topic: python 8.has: documentation This PR adds or changes documentation 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 13, 2020
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to get the final patch release in before removing it, so anyone that would be interested in it could easily cherry-pick it or refer to a Nixpkgs release with it. But, the release is delayed and I don't consider it that important either.

@jonringer
Copy link
Contributor Author

I'll leave this open for a while longer so other can comment, but those are my feelings as well

Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were you I'd just nuke it now @FRidh. Anyone maintaining a fork w/ a long-lived py 3.5 should be sophisticated enough to bump it to the last 3.5.X patch themselves if they're really keen on it.

Though the commitment to top it off and see it through to the end is admirable.

@jonringer
Copy link
Contributor Author

according to the original PEP, https://www.python.org/dev/peps/pep-0478/ , the final release was meant to be out almost a month ago, I don't think we should hold our breath.

Also a lot of "core" packages, that you want to bring in through nixpkgs (E.g. pandas), no longer build.

Not to mention that 0 caching makes it very painful to use this package set.

@jonringer
Copy link
Contributor Author

I could add it to my NUR, and we can have a foot note in the docs . But I would like to discourage people from using it in general

@FRidh FRidh merged commit 49f4475 into NixOS:master Aug 15, 2020
@jonringer jonringer deleted the remove-py35 branch August 15, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.5 removal
4 participants