-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python35: remove #95305
python35: remove #95305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to get the final patch release in before removing it, so anyone that would be interested in it could easily cherry-pick it or refer to a Nixpkgs release with it. But, the release is delayed and I don't consider it that important either.
I'll leave this open for a while longer so other can comment, but those are my feelings as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I were you I'd just nuke it now @FRidh. Anyone maintaining a fork w/ a long-lived py 3.5 should be sophisticated enough to bump it to the last 3.5.X patch themselves if they're really keen on it.
Though the commitment to top it off and see it through to the end is admirable.
according to the original PEP, https://www.python.org/dev/peps/pep-0478/ , the final release was meant to be out almost a month ago, I don't think we should hold our breath. Also a lot of "core" packages, that you want to bring in through nixpkgs (E.g. pandas), no longer build. Not to mention that 0 caching makes it very painful to use this package set. |
I could add it to my NUR, and we can have a foot note in the docs . But I would like to discourage people from using it in general |
Motivation for this change
It's EOL soon, and should be removed before 20.09
closes: #95272
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)