mixxx: 2.2.3 -> 2.2.4

[mmilata]

Motivation for this change

https://github.com/mixxxdj/mixxx/releases/tag/release-2.2.4

Update bot skipped it:

2020-07-05T15:14:47 mixxx 2.2.3 -> 2.2.4 https://repology.org/metapackage/mixxx/versions
2020-07-05T15:15:00 [version] generic version rewriter does not support multiple hashes

@matthiasbeyer can you perhaps check if streaming works for you with the systemwide libshout version? It might, as release notes contain this line:

Add workaround for broken libshout versions mixxxdj/mixxx#2040 mixxxdj/mixxx#2438

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[matthiasbeyer]

Unfortunately I cannot test.

[prusnak]

According to comments in this commit mixxxdj/mixxx@9986605 the build system will use the internal copy if the system-wide libshout has higher version than 2.4.1. That means it does not make sense to try to use the system-wide 2.4.3 version, because it won't be used anyway.

Otherwise ACK.

[matthiasbeyer]

Would it make sense to use our own libshout from a optimization-standpoint? Like,... less stuff compiled from the mixxx sources?

[prusnak]

Would it make sense to use our own libshout from a optimization-standpoint?

That's exactly what is happening. Mixxx uses nix-built libshout, but the older version of it - 2.4.1. If we used newer version, it would be ignored during the build.

[matthiasbeyer]

So nothing to do here anymore, I guess...

[mmilata]

Just checked that streaming works with the systemwide libshout as an input (which the mixxx build recognizes as incompatible and uses internal copy instead).

Advantage of this solution is that no action would be needed when libshout containing bugfix is released. Disadvantage is that it's less clear which version is used.