Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: cleaning up obsolete overrides (2/x) #91508

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jun 25, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

  • class-prelude-yesod: -dontHaddock
  • rank2classes: -dontCheck
  • HaTeX: -dontCheck

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

classy-prelude-yesod: -dontHaddock
rank2classes: -dontCheck
HaTeX: -dontCheck
@cdepillabout
Copy link
Member

cdepillabout commented Jun 26, 2020

@svmhdvn When you send these PRs, can you make sure to run the following types of ofborg commands? This makes it easy for someone to just quickly check if the packages are all still building:

@GrahamcOfBorg build haskellPackages.classy-prelude-yesod
@GrahamcOfBorg build haskellPackages.rank2classes
@GrahamcOfBorg build haskellPackages.HaTeX

(The aarch64 and darwin builders are sometimes not too reliable, so I'm basically looking at the x86_64 Linux ones)

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jun 26, 2020

Sure, I’ll do that on the other PRs, thanks for the info.

@cdepillabout
Copy link
Member

Looks like these three are building on Linux. Thanks!

@cdepillabout cdepillabout merged commit 63de03f into NixOS:haskell-updates Jun 26, 2020
@svmhdvn svmhdvn deleted the overrides-2 branch June 27, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants