-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell: remove obsolete overrides #91435
Conversation
0e28376
to
69dc7a1
Compare
@cdepillabout I will be doing more work on this in the coming days. Would this be better to split up into multiple PRs, perhaps one PR per override removal? Or would you prefer it to be in one large PR? |
@svmhdvn Thanks for working on this!
It doesn't really matter, but it is generally easier to review PRs that affect less packages. However, sending one PR per package is somewhat annoying for the person creating PRs, so maybe 3 to 5 overrides per PR is a good compromise? |
Sounds good, I'll split it up accordingly. |
2afb81a
to
c7cadae
Compare
Motivation for this change
Removing obsolete overrides listed by #86500:
Waiting on upstream for PR/hackage push:
Non-obsolete overrides
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)