Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] chromium: 83.0.4103.97 -> 83.0.4103.106 + VA-API (backport) #90603

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jun 16, 2020

Motivation for this change

Backport of #90538 and #85253 (since it works on nixos-unstable for almost two months now without any bug reports so far and could be useful on 20.03 too, as well as to reduce the differences between 20.03 and nixos-unstable).

Testing status
platform attribute status tester
x86_64 chromium ✔️ @Frostman
x86_64 nixosTests.chromium ✔️ @Frostman
x86_64 google-chrome ✔️ @primeos
aarch64 chromium - -
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

primeos added 2 commits June 16, 2020 13:56
This makes it possible to enable VA-API without having to rebuild
Chromium: `chromium.override { enableVaapi = true; }`

(cherry picked from commit 267eefc)
@ofborg ofborg bot requested review from bendlas and thefloweringash June 16, 2020 12:16
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 16, 2020
@Frostman
Copy link
Member

nixosTests.chromium passed (x86_64)

@primeos primeos merged commit 8056c50 into NixOS:release-20.03 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants