pycurl: Exclude another flaky test #89544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
am bitten by this as well 👍 (fourth rebuild did work out) |
|
I am affected by this and I know more people who are. |
|
@nh2 do you plan to backport this to 20.03? |
|
Okay, latest 20.03 hydra hydra build succeed again for pycurl. https://hydra.nixos.org/job/nixos/release-20.03/nixpkgs.python37Packages.pycurl.x86_64-linux |
jonringer
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
diff LGTM
https://github.com/NixOS/nixpkgs/pull/89544
1 package failed to build:
python27Packages.nixpart0
25 packages built:
pyCA python27Packages.blivet python27Packages.koji python27Packages.nixpart python27Packages.osc python27Packages.pycurl python27Packages.pykickstart python27Packages.urlgrabber python27Packages.wfuzz python37Packages.bugwarrior python37Packages.nvchecker python37Packages.osc python37Packages.patator python37Packages.pycurl python37Packages.urlgrabber wfuzz python38Packages.bugwarrior python38Packages.nvchecker python38Packages.osc python38Packages.patator python38Packages.pycurl python38Packages.urlgrabber python38Packages.wfuzz system-config-printer udocker
10 tasks
|
20.03 backport PR: #90543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #77304 (comment).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Note I've only tested it on
release-20.03. This is the forward-rebase tomasterof that.This should be backported to
release-20.03after merge, because currently 20.03 is flaky.