Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 68.7.0 -> 68.8.0 #87066

Merged
merged 2 commits into from
May 9, 2020
Merged

thunderbird, thunderbird-bin: 68.7.0 -> 68.8.0 #87066

merged 2 commits into from
May 9, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 6, 2020

Motivation for this change
  • Various security fixes (the security advisories are not updated yet)
  • Other fixes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra, lovesegfault and nbp May 6, 2020 07:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 6, 2020
lovesegfault
lovesegfault approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lovesegfault
Copy link
Member

ping @vcunat

vcunat
vcunat approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a quick try they appear to work fine.

@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 9, 2020
@vcunat
Copy link
Member

vcunat commented May 9, 2020

It has some "critical" security fixes.
https://www.thunderbird.net/en-US/thunderbird/68.8.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-18/

@vcunat vcunat merged commit 10134fc into NixOS:master May 9, 2020
vcunat added a commit that referenced this pull request May 9, 2020
@vcunat
Merge #87066: thunderbird*: 68.7.0 -> 68.8.0 (security)
e56fe0e 
https://www.thunderbird.net/en-US/thunderbird/68.8.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-18/
(cherry picked from commit 10134fc)
Re-tested both briefly on 20.03.
vcunat added a commit that referenced this pull request May 10, 2020
@vcunat
Merge #87066: thunderbird*: 68.7.0 -> 68.8.0 (security)
5967390 
https://www.thunderbird.net/en-US/thunderbird/68.8.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-18/
(cherry picked from commit 10134fc)
Re-tested both briefly on 19.09.
@vcunat
Copy link
Member

vcunat commented May 10, 2020

It's in all the three branches now.

stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@vcunat @stigok
Merge NixOS#87066: thunderbird*: 68.7.0 -> 68.8.0 (security)
402db80 
https://www.thunderbird.net/en-US/thunderbird/68.8.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-18/
(cherry picked from commit 10134fc)
Re-tested both briefly on 20.03.
ali-abrar added a commit to obsidiansystems/nixpkgs that referenced this pull request Nov 6, 2020
@ali-abrar
Merge remote-tracking branch 'upstream/nixos-19.09' into reflex-platf…
aec91d9 
…orm-wasm-support

* upstream/nixos-19.09: (795 commits)
  doc: rename guide to 'Nixpkgs Manual'
  libexif: 0.6.21 -> 0.6.22
  gnutls: 3.6.13 -> 3.6.14
  Merge NixOS#89474: thunderbird*: 68.8.0 -> 68.9.0 (security)
  wire-desktop: mac 3.17.3666 -> 3.18.3728
  wire-desktop: linux 3.17.2924 -> 3.18.2925
  ip2unix: 2.1.2 -> 2.1.3
  ip2unix: 2.1.1 -> 2.1.2
  ffmpeg_2_8: 2.8.15 -> 2.8.16
  ffmpeg-full: 4.2.2 -> 4.2.3
  ffmpeg_4: 4.2.2 -> 4.2.3
  pdns-recursor: 4.2.0 -> 4.2.2 (security)
  bind: 9.14.9 -> 9.14.12 (security, PR NixOS#88159)
  dovecot: v2.3.10 → v2.3.10.1
  dovecot: 2.3.9.3 -> 2.3.10
  chromium: Mark as insecure
  firefox: 76.0 -> 76.0.1
  firefox: Add patch to fix AES GCM IV bit size
  monero: fix rcp.restricted option
  Merge NixOS#87066: thunderbird*: 68.7.0 -> 68.8.0 (security)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taku0 @lovesegfault @vcunat