-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.03] keybase,kbfs,keybase-gui: 5.0.0 -> 5.4.2 #86604
Merged
bhipple
merged 8 commits into
NixOS:release-20.03
from
LibreCybernetics:backport-keybase-upgrades
May 3, 2020
Merged
[20.03] keybase,kbfs,keybase-gui: 5.0.0 -> 5.4.2 #86604
bhipple
merged 8 commits into
NixOS:release-20.03
from
LibreCybernetics:backport-keybase-upgrades
May 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a665c1e0c87a1dd97c12940cad9d659b9e22bcd7)
(cherry picked from commit 0c65f3f0d78b2d91df0e2a6819a7f9ce6780549e)
(cherry picked from commit ee2faf31e55cab1192fc57876dff6dce6d561bc3)
(cherry picked from commit 0dbccd06cab066f8e5094b3ed53910e234fff891)
(cherry picked from commit d47ddc636b134e4070b0c7cbee6a879bb7992005)
(cherry picked from commit 3f8e7741cf723b36a278750614036bebbd74e9c6)
(cherry picked from commit e1820dc344d36c27b3b8a81fbd3274d50041cb66)
(cherry picked from commit 0a7e9c3d5d9082a0f1d153f4f4b1d912429aef10)
ofborg
bot
requested review from
bennofs,
Br1ght0ne,
np,
Avaq,
carlsverre,
puffnfresh and
ehmry
May 2, 2020 17:57
I just built this on nixos with sandboxing and verified that kbfs, keybase, keybase-gui and the keybase daemon are working as expected. |
Result of 3 packages built:- kbfs - keybase - keybase-gui |
bhipple
approved these changes
May 3, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Keybase has shipped many bugfixes and an essential features (blocking other people) since this is a security focused tool backporting this version upgrades from nixpkgs/master would be desirable.
Bufixes of features available on 5.0.0 from upstream:
5.1.0:
5.1.1:
5.2.0:
5.2.1:
5.3.0:
5.3.1:
5.4.0:
n/a (only feature additions and fixes of feature additions after 5.0.0)
5.4.1:
5.4.2:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)