-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmux: install manpages #86296
tmux: install manpages #86296
Conversation
pkgs/tools/misc/tmux/default.nix
Outdated
@@ -23,7 +23,7 @@ stdenv.mkDerivation rec { | |||
pname = "tmux"; | |||
version = "3.1"; | |||
|
|||
outputs = [ "out" "man" ]; | |||
outputs = [ "out" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is redundant if you only want to have the "out"
output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dom't believe removing the man output is the solution.
I am not sure how nix-shell and MANPATH interact
nix-shell --pure -p tmux.man man
does not find the man but my installed tmux brings up the manpage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is redundant if you only want to have the
"out"
output.
Oh yes, I agree. I'll change this in a second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dom't believe removing the man output is the solution.
I am not sure how nix-shell and MANPATH interact
nix-shell --pure -p tmux.man man
does not find the man but my installed tmux brings up the manpage
Okay, weird, it doesn't work for me. But it's not terribly important. I'll await further guidance how to proceed. :-) Thank you two of your review!
👎 the multiple-output feature exists for a reason: https://nixos.org/nixpkgs/manual/#chap-multiple-output I'm not 100% sure why the MANPATH isn't properly configured on
Is it possible that |
This should be closed in favor of either of: |
Thank you @doronbehar, I agree this should be closed in favor of the other issues/pull requests. I did not notice these before. Thank you for your work on our documentation system! |
Motivation for this change
On current master,
man tmux
comes empty after in anix-shell -p tmux
. This pull request fixes that.However, I'm a little bit unsure whether this is the correct procedure. I looked at other packages for guidance, but didn't spot a consistent pattern. The packages
feh
andvdr
both use multiple outputs, astmux
did before this pull request; the manpages forfeh
are installed correctly and these forvdr
are not.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)