Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nvidia prime render offload #86094

Closed
wants to merge 7 commits into from
Closed

[20.03] nvidia prime render offload #86094

wants to merge 7 commits into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu mentioned this pull request Apr 27, 2020
Merged
10 tasks
eadwu and others added 7 commits April 26, 2020 22:47
@eadwu
nixos/nvidia: remove lib references
4837679 
(cherry picked from commit 5d21e8c)
@eadwu
nixos/nvidia: optimus_prime -> prime.sync
a5c8d9f 
(cherry picked from commit aca9ffe)
@eadwu
nixos/nvidia: prime.sync.{intel,nvidia}BusId -> prime.{intel,nvidia}B…
3651979 
…usId

(cherry picked from commit e8daa1e)
@eadwu
nixos/xserver: introduce attr display to xserver.drivers
0886632 
Specifically for NVIDIA so that only the device section would be created

(cherry picked from commit 632a8a7)
@eadwu
nixos/nvidia: implement prime render offload
61826db 
(cherry picked from commit 026b601)
@eadwu
nvidia_x11: fix *nvidia*.so* references
50ca1ec 
(cherry picked from commit d48ed3b)
@eadwu
nvidia_x11: include libdrm in rpath
cfc0ecd 
Needed for PRIME render offload specifically

(cherry picked from commit 3b38766)
@eadwu eadwu force-pushed the 20.03/nvidia-prime-render-offload branch from 5e6d873 to cfc0ecd Compare April 27, 2020 02:48
@eadwu
Copy link
Member Author

eadwu commented Apr 27, 2020

Since this missed the release window, should I remove the mkRenamedOptionModules?

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 27, 2020
@ofborg ofborg bot requested a review from baracoder April 27, 2020 02:56
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Apr 27, 2020
@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label May 11, 2020
@eadwu eadwu marked this pull request as ready for review May 14, 2020 04:12
@Ekleog
Copy link
Member

Ekleog commented Jun 12, 2020 •
edited
Loading

Thank you for this PR!

Unfortunately, this looks to me like too much changes to reasonably make it happen in 20.03, especially seeing as it's not a bugfix but a new feature.

Feel free to let me know if there's something I missed! Otherwise, unfortunately it means having to wait until 20.09 to have this in stable, but such is the cost of stability :/

@Ekleog Ekleog closed this Jun 12, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

😞

@nh2 nh2 mentioned this pull request Jun 15, 2020
Open
@eadwu eadwu deleted the 20.03/nvidia-prime-render-offload branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder Awaiting requested review from baracoder

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eadwu @Ekleog @prusnak