Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/acme: Fix postRun in acme certificate being ran at every run #85365

Merged
merged 1 commit into from
Apr 18, 2020
Merged

nixos/acme: Fix postRun in acme certificate being ran at every run #85365

merged 1 commit into from
Apr 18, 2020

Conversation

immae
Copy link
Contributor

@immae immae commented Apr 16, 2020

Motivation for this change

This fixes the third checkbox of issue #84633
currently everytime the acme job is started, it runs the postRun hook, which is not a sensible thing to do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Apr 16, 2020
Merged
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 16, 2020
@immae
Copy link
Contributor Author

immae commented Apr 16, 2020

cc @arianvp @emilazy @m1cr0man @aanderse @flokli

@immae immae force-pushed the fix_acme_postrun branch from 2c49bef to 8e88b8d Compare April 17, 2020 20:17
@flokli flokli requested a review from aanderse April 18, 2020 16:24
@worldofpeace worldofpeace changed the title Fix postRun in acme certificate being ran at every run nixos/acme: Fix postRun in acme certificate being ran at every run Apr 18, 2020
@worldofpeace worldofpeace merged commit 996ae85 into NixOS:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@m1cr0man m1cr0man m1cr0man approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@immae @m1cr0man @emilazy @worldofpeace