pythonPackages.psycopg2cffi: init at 2.8.1 #84466
Conversation
ofborg
bot
added
6.topic: python
8.has: package (new)
|
Edit: Nevermind. The issue is unrelated to this package (#39356), and upstream from nixpkgs anyway (pypa/pip#7629) |
|
ofborg
bot
added
the
11.by: package-maintainer
My bad, added now. I forgot hydra doesn't compile with pypy by default so this is supposedly mergeable now. |
| buildInputs = [ six ] ++ lib.optional stdenv.isDarwin openssl; | ||
| nativeBuildInputs = [ cffi postgresql ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why are the tests disabled? Please include a comment.
There was a problem hiding this comment.
The same reason they're disabled here (with no comment) https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/psycopg2/default.nix#L17 since this is a fork - you'd presumably know the reason better than me...
| sha256 = "0yc0cxxkfr35kd959wsagxfhy6ikbix71rp9x0rmn858fxa4vapw"; | ||
| }; | ||
|
|
||
| buildInputs = [ six ] ++ lib.optional stdenv.isDarwin openssl; |
There was a problem hiding this comment.
are six and cffi only needed during build-time, not run-time?
There was a problem hiding this comment.
Same with openssl. With cffi one opens a library, so its important the Python library knows where to find it. Often it needs to be hardcoded.
There was a problem hiding this comment.
I'm not entirely sure, since for my use case this doesn't currently work. What would I have to change if it were?
|
No longer interested in this package... |
Motivation for this change
psycopg2cffi for pypy3
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)