Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] matrix-synapse: 1.11.1 -> 1.12.0 #83516

Merged
merged 3 commits into from
Apr 1, 2020
Merged

[19.09] matrix-synapse: 1.11.1 -> 1.12.0 #83516

merged 3 commits into from
Apr 1, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 27, 2020

Motivation for this change

Backport PR for #83239

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 @Ma27
matrix-synapse: 1.11.1 -> 1.12.0
1881b34 
(cherry picked from commit 425efa5)
@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 27, 2020
@Ma27 Ma27 requested a review from FRidh as a code owner March 27, 2020 18:03
@Ma27
Copy link
Member Author

Ma27 commented Mar 27, 2020

@GrahamcOfBorg test matrix-synapse

@ofborg ofborg bot requested review from Ralith and Ekleog March 27, 2020 18:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 27, 2020
@Ma27
Copy link
Member Author

Ma27 commented Mar 28, 2020

cc @NixOS/backports any objections?

worldofpeace
worldofpeace approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, keep fighting the good fight of python dependencies!!!!!
We will be victorious 😂

@Ma27 Ma27 requested a review from worldofpeace March 29, 2020 20:00
@Ma27
Copy link
Member Author

Ma27 commented Mar 31, 2020

@NixOS/backports any further objections? :)

@lheckemann lheckemann merged commit d011e47 into NixOS:release-19.09 Apr 1, 2020
@Ma27 Ma27 deleted the synapse-19.09 branch April 1, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@mguentner mguentner Awaiting requested review from mguentner

@fadenb fadenb Awaiting requested review from fadenb

@ajs124 ajs124 Awaiting requested review from ajs124

@pacien pacien Awaiting requested review from pacien

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@Ralith Ralith Awaiting requested review from Ralith

@Ekleog Ekleog Awaiting requested review from Ekleog

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ma27 @FRidh @worldofpeace @lheckemann @ajs124