Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09 unblock] grafana: Drop Frostman from maintainers #83109

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Mar 22, 2020

@Frostman is not in maintainers-list.nix on 19.09.
This fails the build of the channel and tarball jobs on the small
jobset.

Follow-up of #83102

@Frostman is not in maintainers-list.nix on 19.09.
This fails the build of the `channel` and `tarball` jobs on the small
jobset.

Follow-up of NixOS#83102
@dasJ
Copy link
Member Author

dasJ commented Mar 22, 2020

cc @Ma27

@dasJ dasJ closed this Mar 22, 2020
@dasJ dasJ reopened this Mar 22, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 22, 2020

Oof... sorry for the broken backport! :/

@Ma27
Copy link
Member

Ma27 commented Mar 22, 2020

@GrahamcOfBorg eval

@Ma27
Copy link
Member

Ma27 commented Mar 22, 2020

I assume that the eval here fails since the current state of 19.09 doesn't evaluate.

Running e.g. nix-instantiate --eval --strict -A grafana.meta confirms that the meta-section of pkgs.grafana is unbroken now -> merging.

@Ma27 Ma27 merged commit 8b8e73a into NixOS:release-19.09 Mar 22, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 22, 2020

@dasJ - thanks for fixing this and sorry, those kind of errors shouldn't happen :/

@dasJ dasJ deleted the bp-drop-frostman branch March 22, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants