Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] backport protonvpn cli ng #81952

Merged
merged 5 commits into from
Mar 7, 2020
Merged

[19.09] backport protonvpn cli ng #81952

merged 5 commits into from
Mar 7, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 7, 2020 •
edited
Loading

Motivation for this change

protonvpn-cli is not supported anymore by protonvpn. protonvpn-cli-ng is the cli recommanded by ProtonVPN

(see https://github.com/ProtonVPN/protonvpn-cli-ng).

Things done

For pythondialog, it brings init from PR #68636 and update from #75361 and #76059 .
For protonvpn-cli-ngL it brings init from PR #77407 and update to 2.2.2 from PR #81735 .

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mbrgm and others added 5 commits March 6, 2020 22:44
@mbrgm @JeffLabonte
pythondialog: init at 3.4.0
a715159 
This is required to install protonvpn-cli-ng

(cherry picked from commit ebaedb0)
Reason: The supported version of protonvpn-cli-ng requires this
dependency
@r-ryantm @JeffLabonte
python38Packages.pythondialog: 3.4.0 -> 3.5.0
2162798 
Keep the version of pythondialog up-to-date

(cherry picked from commit 875524d)
Reason: Required for the supported version of protonvpn-cli-ng
@FRidh @JeffLabonte
python: pythondialog: 3.5.0 -> 3.5.1
2f37837 
Take it to the latest version!

(cherry picked from commit f41e2ca)
Reason: Keep the latest version for protonvpn-cli-ng
@jtcoolen @JeffLabonte
protonvpn-cli-ng: init at 2.2.0
2bf7911 
Take the supported version of protonvpn

(cherry picked from commit b45c4d2)
Reason: protonvpn-cli is not supported anymore, it has been replaced by
this package
@JeffLabonte
protonvpn-cli-ng: 2.2.0 -> 2.2.2
5d60424 
Simply keep up to date the cli since it is used to connect to a VPN.

(cherry picked from commit eb96574e9df3aba387c4abe902b154398271becf)
Reason: A tool to communicate with a VPN provider should be kept
up-to-date
@JeffLabonte JeffLabonte requested a review from FRidh as a code owner March 7, 2020 03:59
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package labels Mar 7, 2020
@ofborg ofborg bot requested a review from jtcoolen March 7, 2020 04:05
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 7, 2020
@FRidh FRidh merged commit a81842b into NixOS:release-19.09 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jtcoolen jtcoolen Awaiting requested review from jtcoolen

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffLabonte @FRidh @mbrgm @r-ryantm @jtcoolen