Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/parsoid: fix service by reinstating nodePackages.parsoid #80998

Merged
merged 3 commits into from
Feb 25, 2020
Merged

nixos/parsoid: fix service by reinstating nodePackages.parsoid #80998

merged 3 commits into from
Feb 25, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 25, 2020 •
edited
Loading

Fixes services.parsoid (MediaWiki VisualEditor backend) which does not work at least since 2b8cde0. Also enables systemd sandboxing, namely DynamicUser which fixes #55370.

Motivation for this change

The nixos/parsoid module is currently broken because it referes to nonexistent package:

error: attribute 'parsoid-git://github.com/abbradar/parsoid#stable' missing, at /nix/store/kyf94wnik8sx13csarz8cjajgw1jaswb-source/nixos/modules/services/misc/parsoid.nix:9:13
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @abbradar @aanderse @Mic92

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 25, 2020
Mic92
Mic92 reviewed Feb 25, 2020
View reviewed changes
nixos/modules/services/misc/parsoid.nix
@@ -98,8 +98,29 @@ in
wantedBy = [ "multi-user.target" ];
after = [ "network.target" ];
serviceConfig = {
User = "nobody";
Copy link
Member

@Mic92 Mic92 Feb 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nobody should be never used actually for services.

@Mic92 Mic92 merged commit e23f941 into NixOS:master Feb 25, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 25, 2020

That might be a good candidate for backporting... However its a bit tricky because the node-package set needs to be regenerated for 20.03.

@mmilata mmilata mentioned this pull request Feb 25, 2020
Merged
10 tasks
@mmilata mmilata deleted the parsoid branch February 25, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nobody/nogroup shouldn't be used
2 participants
@mmilata @Mic92