Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/matrix-synapse, nixos/mxisd: fix empty usernames #77344

Merged
merged 2 commits into from
Jan 9, 2020
Merged

nixos/matrix-synapse, nixos/mxisd: fix empty usernames #77344

merged 2 commits into from
Jan 9, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 8, 2020

Motivation for this change

It appears #77177 accidently sets the username of the matrix-synapse user to "" (emtpy).
This causes the service fail.

I havent' tested the mxisd service but it seems it will have the same issue, so a fix is also included

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @petabyteboy @worldofpeace

@bachp bachp changed the title Fix empty usernames Fix empty usernames for matrix-synapse and mxisd Jan 8, 2020
@bachp bachp changed the title Fix empty usernames for matrix-synapse and mxisd nixos/matrix-synapse, nixos/mxisd: fix empty usernames Jan 8, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2020
@worldofpeace worldofpeace merged commit f8d70be into NixOS:master Jan 9, 2020
@worldofpeace
Copy link
Contributor

Thanks @bachp

@worldofpeace
Copy link
Contributor

For ref the issue is #77189.

@bachp bachp deleted the fix-empty-usernames branch January 9, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bachp @worldofpeace