Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treewide: update some problematic homepages #75270

Merged
merged 1 commit into from
Dec 8, 2019
Merged

Treewide: update some problematic homepages #75270

merged 1 commit into from
Dec 8, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 8, 2019

Motivation for this change

These URLs are reported as problematic by Repology.
It could be a permanent redirection or the page does not exist anymore.

Related issue: #60004

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer (concerns a fair number of python pkgs)

@c0bw3b
Treewide: update some problematic homepages
22fd7f8 
These URLs are reported as problematic by Repology.
It could be a permanent redirection
or the page does not exist anymore
@ofborg ofborg bot added 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 8, 2019
jonringer
jonringer approved these changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this! :)

pkgs/development/python-modules/extras/default.nix
description = "A module provides basic functions for parsing mime-type names and matching them against a list of media-ranges";
homepage = https://code.google.com/p/mimeparse/;
description = "Useful extra bits for Python - things that should be in the standard library";
homepage = "https://github.com/testing-cabal/extras";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, good catch

@jonringer jonringer merged commit 69b393a into NixOS:master Dec 8, 2019
@c0bw3b c0bw3b deleted the enh/urls-redir branch December 8, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: hygiene 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0bw3b @jonringer