Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nvidia: include systemd power management #73530

Merged
merged 1 commit into from
May 12, 2020
Merged

nixos/nvidia: include systemd power management #73530

merged 1 commit into from
May 12, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Nov 17, 2019 •
edited
Loading

Motivation for this change

#73494

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 17, 2019
@eadwu eadwu force-pushed the nvidia/systemd-pm branch from 14231f4 to 70c6ff9 Compare November 17, 2019 02:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Nov 17, 2019
flokli
flokli reviewed Nov 17, 2019
View reviewed changes
nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved
@eadwu eadwu force-pushed the nvidia/systemd-pm branch 2 times, most recently from dee70c0 to 6f6746f Compare November 17, 2019 21:58
@eadwu eadwu force-pushed the nvidia/systemd-pm branch 2 times, most recently from 325dcf5 to ee94f3b Compare November 20, 2019 02:31
@eadwu eadwu force-pushed the nvidia/systemd-pm branch from ee94f3b to 9d09bb3 Compare November 21, 2019 02:22
@eadwu eadwu mentioned this pull request Nov 21, 2019
Closed
@eadwu eadwu marked this pull request as ready for review November 26, 2019 02:13
@lovesegfault
Copy link
Member

What's the status on this @eadwu @flokli?

@eadwu
Copy link
Member Author

eadwu commented Mar 1, 2020 •
edited
Loading

I'm waiting for #66601 to get merged before pushing for this since it will introduce conflicts.

Doesn't seem anyone is having critical issues with NVIDIA to push for this right now.

@eadwu eadwu force-pushed the nvidia/systemd-pm branch from 9d09bb3 to 7d5b1ec Compare March 2, 2020 02:06
@eadwu eadwu force-pushed the nvidia/systemd-pm branch from 7d5b1ec to f51e573 Compare April 7, 2020 18:16
@eadwu eadwu force-pushed the nvidia/systemd-pm branch from f51e573 to fae0c20 Compare May 10, 2020 15:24
@eadwu eadwu force-pushed the nvidia/systemd-pm branch from fae0c20 to 9a269f5 Compare May 10, 2020 15:26
@flokli flokli requested a review from lovesegfault May 11, 2020 13:36
@Mic92
Copy link
Member

Mic92 commented May 11, 2020

#66601 is merged now.

lovesegfault
lovesegfault reviewed May 11, 2020
View reviewed changes
nixos/modules/hardware/video/nvidia.nix
Comment on lines +59 to +60
Experimental power management through systemd. For more information, see
the NVIDIA docs, on Chapter 21. Configuring Power Management Support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these docs are publicly available, then a link would be nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are within each package, so pinning the doc has the possibility of the docs becoming outdated (I'm not sure if there's a link for the "latest" package).

Then again, I could probably do something along the lines of https://download.nvidia.com/XFree86/Linux-x86_64/${nvidia_x11.version}/README/powermanagement.html but not sure if a package evaluation should be done just for the option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair :)

lovesegfault
lovesegfault approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@flokli flokli merged commit d6f90e4 into NixOS:master May 12, 2020
@nh2 nh2 mentioned this pull request Jun 15, 2020
Open
nh2
nh2 reviewed Jun 21, 2021
View reviewed changes
nixos/modules/hardware/video/nvidia.nix
path = with pkgs; [ kbd ];
serviceConfig = {
Type = "oneshot";
ExecStart = "${nvidia_x11.out}/bin/nvidia-sleep.sh '${state}'";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken with new driver due to conditional install (silent failure in package install process from this PR) if the script doesn't exist:

#127693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@nh2 nh2 nh2 left review comments

@flokli flokli flokli left review comments

@mweinelt mweinelt mweinelt left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eadwu @lovesegfault @Mic92 @mweinelt @flokli @nh2