-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pycurl: disable flakey memory tests #72039
Conversation
for the port to stable, you may need to cherry-pick a few commits:
|
the 4 broken, are broken on master: broken builds logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably be insufficient, as there are other kinds of failing tests; see eg. #55945 (comment). I don't know if anyone has figured out a common cause yet, but if not, we should probably just disable the tests entirely so as to not break builds?
Even if it's insufficient, people are still having difficulties on it in a non-deterministic manner |
|
Right, I get that. My point is that those non-deterministic issues aren't solved by the current changes because they occur in other tests as well. |
other than submitting an issue upstream, which some may be nixos specific, I'm not sure what to do |
Disabling the install check is the workaround I've applied locally to make the build succeed, and perhaps that'd be the right thing to do here, at least until the root cause gets fixed. It's perhaps a bit rigorous, but given that the failures occur in various completely unrelated tests, I'm not sure there are any other options - it looks to me like the problem is in how the tests get run (unintentional concurrency?), not in any one specific test, and so any non-concurrency-safe test might fail. |
Closing, no desire currently to tackle this |
@GrahamcOfBorg build python3Packages.pycurl |
this was merged, not sure why github just shows it as me pushing to master |
Motivation for this change
fixes #71975
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @