criterion: init at version 2.3.3

[Thesola10]

Motivation for this change

There is currently no true distro-agnostic way to install the criterion library on Linux, and I thought Nix was a good choice.

Note: boxfort does not have official tagging/versioning, so I set the version attribute to be the commit hash (like GitHub does).

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/) (does not apply, but generated libraries work properly.)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @aanderse

[Thesola10]

I hope this is not a duplicate to #44911

[Thesola10]

Also, while reading through #44911 I found out that the unstable versioning scheme should be unstable-YYYY-MM-DD. Should I update it to that format?

[aanderse]

I'm entirely unsure why I was specifically mentioned on this PR... but while I'm here, a few things I noticed 😄

[aanderse]

Is this a problem with BoxFort? If a fix for this can be applied in BoxFort instead of here that would be more desirable as every package/developer on nix using BoxFort conceivably has to implement this workaround.

[Thesola10]

Seeing as pkg-config goes undetected the same way, I don't think it's a boxfort problem.

[Thesola10]

So, is it resolved or no?

[jonringer]

I've seen i where some people will just see if a directory exists, instead of using the find_packge command. I think this is alright, but it would probably be good to open a ticket upstream

[Thesola10]

Will do. I'm assuming all reqs are cleared and we can merge, right? It still says "changes requested"

[aanderse]

I notice the other PR didn't have need to add this .third-party directory.

[Thesola10]

I suspect their modification of $LD_LIBRARY_PATH fixed it on their side, I tested it locally and it works

[Thesola10]

Oh and @aanderse I mentioned you because you're the one who merged my previous PR #58960 since the PR template now says "Notify maintainers" sorry for the inconvenience

[aanderse]

@Thesola10 Ahh ok. Absolutely no problem at all! Feel free to ping me any time 😄 I was just unsure and thought maybe I should know something about this PR that I didn't. I'm always happy to help if I'm able and feel flattered you'd mention me 👍

[Thesola10]

By the way, are we good to merge? It still says “Changes requested”.

[Thesola10]

Also I recently found out about #70403 and I'm wondering if my PR is a dupe. If that one's more likely to be merged I don't mind giving up this PR.

[aanderse]

@Thesola10 You have accidentally added 2 commits to this PR from someone else.

I'd ask that you and @Yumasi decide which PR to go forward with, add both of you as maintainers, and then close the other PR and then we can proceed.

Thanks for your hard work so far! We're almost there.

[Thesola10]

After a (very brief) discussion with @Yumasi we have decided that their PR would go through. I am as such closing mine, and will not be maintaining the criterion and boxfort packages. Instead I will help in #70403 wherever possible prior to merging.

Thanks