Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cwm: init. Added windowManager cwm, basing on the module for dwm. #70035

Merged
merged 2 commits into from
Oct 9, 2019
Merged

nixos/cwm: init. Added windowManager cwm, basing on the module for dwm. #70035

merged 2 commits into from
Oct 9, 2019

Conversation

mkf
Copy link
Contributor

@mkf mkf commented Sep 29, 2019

Added windowManager cwm, basing on the module for dwm.

Motivation for this change

Necessary to enable cwm window manager as a choice from display managers.

Things done

Added config.services.xserver.windowManager.cwm just like config.services.xserver.windowManager.dwm.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @0x4A6F

@mkf
nixos/cwm: init
d9a7c51 
Added windowManager cwm, basing on the module for dwm.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 29, 2019
@romildo romildo self-requested a review October 7, 2019 14:18
romildo
romildo requested changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add cwm to the list of imports in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/window-managers/default.nix#L14

romildo
romildo approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a VM.

@romildo romildo merged commit f251c29 into NixOS:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkf @romildo @0x4A6F