Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub2: 2.04-rc1 -> 2.04 #67622

Merged
merged 1 commit into from
Sep 2, 2019
Merged

grub2: 2.04-rc1 -> 2.04 #67622

merged 1 commit into from
Sep 2, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

Stable release, would look nice to have this in 19.09 instead of an RC.

nix-build -A nixosTests.installer succeeded (seemed to be the most relevant test case for GRUB); my machine also came up again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@worldofpeace
Copy link
Contributor

News for 2.04, not sure how much changed from the rc

New in 2.04:

* GCC 8 and 9 support.
* Gnulib integration overhaul.
* RISC-V support.
* Xen PVH support.
* Native UEFI secure boot support.
* UEFI TPM driver.
* New IEEE 1275 obdisk driver.
* Btrfs RAID 5 and RIAD 6 support.
* PARTUUID support.
* VLAN support.
* Native DHCP support.
* Many ARM and ARM64 fixes.
* Many SPARC fixes.
* Many IEEE 1275 fixes.
* ...and tons of other fixes and cleanups...

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 28, 2019
@worldofpeace worldofpeace added this to the 19.09 milestone Aug 28, 2019
jonringer
jonringer approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 fails, but broken on master)
diff LGTM
binaries seem to work

[21 built (1 failed), 258 copied (924.7 MiB), 227.5 MiB DL]
error: build of '/nix/store/xlplllqg0yngg837ccwcr6rg90vsfzrx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67622
1 package failed to build:
deepin.deepin-wm

19 package were build:
deepin.dde-api deepin.dde-control-center deepin.dde-daemon deepin.dde-dock deepin.dde-file-manager deepin.dde-launcher deepin.dde-session-ui deepin.deepin-desktop-base deepin.deepin-desktop-schemas deepin.deepin-metacity deepin.deepin-mutter deepin.deepin-wallpapers grub2 grub2_efi grub2_light grub2_pvgrub_image grub2_xen os-prober woeusb

@disassembler
Copy link
Member

@GrahamcOfBorg test installer

@disassembler
Copy link
Member

rebased. installer test is passing, so merging!

@disassembler disassembler merged commit 8ba94a8 into NixOS:master Sep 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 3, 2019
@herrwiese @dtzWill
grub2: 2.04-rc1 -> 2.04 (NixOS#67622)
687a30d 
(cherry picked from commit 8ba94a8)
lheckemann added a commit that referenced this pull request Oct 4, 2019
@lheckemann
Revert "grub2: 2.04-rc1 -> 2.04 (#67622)"
4eb9725 
This reverts commit 8ba94a8.

See #61718 for rationale.
samueldr pushed a commit to samueldr/nixpkgs that referenced this pull request Dec 8, 2019
@herrwiese @samueldr
[DROP] grub2: 2.04-rc1 -> 2.04 (NixOS#67622)
2242e3e 
(cherry picked from commit 8ba94a8)
@herrwiese herrwiese deleted the grub-2.04 branch April 1, 2020 22:54
infinisil pushed a commit to infinisil/nixpkgs that referenced this pull request Apr 21, 2020
@lheckemann @infinisil
Revert "grub2: 2.04-rc1 -> 2.04 (NixOS#67622)"
73fcd45 
This reverts commit 8ba94a8.

See NixOS#61718 for rationale.

(cherry picked from commit 4eb9725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.
4 participants
@herrwiese @worldofpeace @disassembler @jonringer