pythonPackages.imgaug: 0.3.0-patch

[Rakesh4G]

Added patch to bypass opencv-python dependency from imgaug

@CMCDragonkai

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @CMCDragonkai @FRidh

[Rakesh4G]

package has been updated as per inputs from

#61936

aleju/imgaug#379 (comment)

[CMCDragonkai]

Note that in the master branch of imgaug, the author has changed to opencv-python-headless from opencv-python. See: https://github.com/aleju/imgaug/blob/master/setup.py#L21.

This means for this release 0.2.9, it should work, but the next release may require a change to the substitute patch.

[CMCDragonkai]

Approved, looks good. Mark it ready for review.

[mmahut]

@GrahamcOfBorg build python37Packages.imgaug

[mmahut]

Looks like resulting derivation is empty?

[nix-shell:~/.cache/nix-review/pr-67494/results/python37Packages.imgaug]# tree
.
└── nix-support
    └── propagated-build-inputs

1 directory, 1 file

[CMCDragonkai]

This is blocked on aleju/imgaug#414

[jonringer]

do you mind rebasing on top of master? apparently there's some merge conflicts:

git pull -r origin master
git push <fork> <branch> --force

[Rakesh4G]

do you mind rebasing on top of master? apparently there's some merge conflicts:

git pull -r origin master
git push <fork> <branch> --force

Sure, I will.

[tbenst]

Given that imgaug is functioning on waiting on upstream for a fix, perhaps we should merge & fix broken package?

[Rakesh4G]

The tests hang issue aleju/imgaug#414 with imgaug-0.3.0 has been fixed on master. I have taken the latest changes and current expression is ready to be merged.
@tbenst @CMCDragonkai @jonringer

[CMCDragonkai]

When attempting to install the latest changes using nix-env -f ./default.nix -iA 'pkgs.python3Packages.imgaug, the tests for hang here:

test/augmenters/test_meta.py::TestAugmenter_augment_batches::test_augment_batches_list_of_list_of_invalid_datatype PASSED

The build just stops there, the pytest command is still running but with 0% CPU usage.

[Rakesh4G]

nix-env -f ./default.nix -iA 'pkgs.python3Packages.imgaug

@CMCDragonkai
yes, you are correct. I am also facing this hang issue with above command you mentioned.
looks like i had missed something. I will re-inspect and see what is going wrong.

[Rakesh4G]

I have updated the error details and other findings on aleju/imgaug#414

[Rakesh4G]

This PR is ready for merge. All the tests are now passing.
@tbenst @jonringer @CMCDragonkai

[jonringer]

diff LGTM
commit LGTM
tests pass 👍

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67494
1 package were built:
python37Packages.imgaug

[jonringer]

@GrahamcOfBorg build python37Packages.imgaug

[CMCDragonkai]

I believe those Darwin problems are the same as NixOS problems until imgaug maintainers disabled those tests on NixOS platform. But not on Mac.

…

On 20 December 2019 06:08:30 GMT+11:00, Jon ***@***.***> wrote: jonringer commented on this pull request. > meta = with stdenv.lib; { homepage = https://github.com/aleju/imgaug; description = "Image augmentation for machine learning experiments"; license = licenses.mit; - maintainers = with maintainers; [ cmcdragonkai ]; - broken = true; # opencv-python bindings aren't available yet, and look non-trivial + maintainers = with maintainers; [ cmcdragonkai rakesh4g ]; ```suggestion maintainers = with maintainers; [ cmcdragonkai rakesh4g ]; platforms = platforms.linux; ``` looks like darwin has odd behavior: ``` Current thread 0x0000700003d9d000 (most recent call first): File "/private/tmp/nix-build-python3.7-imgaug-0.3.0.drv-0/imgaug-c3d99a420efc45652a1264920dc20378a54b1325/imgaug/augmenters/blur.py", line 262 in blur_gaussian_ File "/private/tmp/nix-build-python3.7-imgaug-0.3.0.drv-0/imgaug-c3d99a420efc45652a1264920dc20378a54b1325/imgaug/augmenters/blur.py", line 466 in _augment_batch File "/private/tmp/nix-build-python3.7-imgaug-0.3.0.drv-0/imgaug-c3d99a420efc45652a1264920dc20378a54b1325/imgaug/augmenters/meta.py", line 606 in augment_batch File "/private/tmp/nix-build-python3.7-imgaug-0.3.0.drv-0/imgaug-c3d99a420efc45652a1264920dc20378a54b1325/imgaug/multicore.py", line 506 in _Pool_worker File "/private/tmp/nix-build-python3.7-imgaug-0.3.0.drv-0/imgaug-c3d99Fatal Python error: Segmentation fault ``` -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #67494 (review)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[CMCDragonkai]

We don't have Mac platforms to test this. So we could forward on the details to imgaug maintainer. While also just only enabling this for Linux?

[CMCDragonkai]

Another idea is a patch in Nix package level that disables those specific tests.

[jonringer]

personally, I would either do doCheck = stdenv.isLinux or meta.platforms = platforms.linux. The meta platform is probably more appropriate if we don't have some other form of testing.

[Rakesh4G]

I have updated the requested changes. Thanks.
@FRidh @jonringer @CMCDragonkai

[jonringer]

@GrahamcOfBorg build python37Packages.imgaug

[tbenst]

I cherry-picked this patch and has been working for me! would love to see merged