-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perl: fix errant references when cross-compiling #65761
Conversation
I guess we need some special case for the Darwin bootstrap perl. I'm not sure what package provides |
Oh, I see #58979 ran into the same problem. |
f1cae2e
to
4f7d24b
Compare
I applied the |
4f7d24b
to
a77c9e2
Compare
a77c9e2
to
3084045
Compare
Sorry, I accidentally rebased on master... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the comments outside the ''...''
that way they don't affect the drv. Otherwise looks good!
3084045
to
49afaab
Compare
I fixed the comments. |
Thank you! |
Motivation for this change
Cross-compiled Perl ends up with references to its source tarball and build
coreutils
.Things done
The source tarball reference was a bit perplexing, but it turns out that Perl's build system uses the
src
environment variable, and writes its value into a header in the output. For native builds, some part of the config ends up of overwriting this variable, but this does not happen when cross-compiling.The
coreutils
reference was simply an assumption that the correct binary would be inPATH
.sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @edolstra