Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-vipaccess: init at 0.10.3 #65570

Merged
merged 2 commits into from
Aug 5, 2019
Merged

pythonPackages.python-vipaccess: init at 0.10.3 #65570

merged 2 commits into from
Aug 5, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

python-vipaccess is a free and open source software (FOSS) implementation of Symantec's VIP Access client. This, for example, allows provisioning TOTP on PayPal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@herrwiese herrwiese requested a review from FRidh as a code owner July 29, 2019 20:57
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 29, 2019
worldofpeace
worldofpeace suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that oath tests succeed and builds appropriately.

Following comments are just expression style.

pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vipaccess/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vipaccess/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-vipaccess/default.nix Outdated Show resolved Hide resolved
@worldofpeace worldofpeace mentioned this pull request Aug 5, 2019
Open
@worldofpeace
Copy link
Contributor

Made a report upstream about fixing up the tests dlenski/python-vipaccess#30.

worldofpeace
worldofpeace approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit 838bb4c into NixOS:master Aug 5, 2019
@herrwiese herrwiese deleted the python-vipaccess branch August 5, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@FRidh FRidh FRidh requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@herrwiese @worldofpeace @risicle @FRidh