Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune: 1.10.0 -> 1.11.0 #65127

Merged
merged 1 commit into from
Jul 24, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkgs/development/tools/ocaml/dune/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

stdenv.mkDerivation rec {
pname = "dune";
version = "1.10.0";
version = "1.11.0";
src = fetchurl {
url = "https://github.com/ocaml/dune/releases/download/${version}/dune-${version}.tbz";
sha256 = "15fx9rg16g7ig43rg4sdq0wp0br5h1mjxxgv8b15s317vqlfc5pd";
url = "https://github.com/ocaml/dune/releases/download/${version}/dune-build-info-${version}.tbz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the hash is wrong now.

Copy link
Contributor Author

@marsam marsam Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated the hash.
About the .tbz name seems to be related to ocaml/dune#2224, and it is the same that dune declares in the opam archive https://github.com/ocaml/opam-repository/pull/14567/files#diff-a081995843fd7c2880ab94240401e49bR48

sha256 = "11jl2vavypbgvwblch25q10hsd16myik9b3cd4d64zhxk1fzbzdw";
};

buildInputs = [ ocaml findlib ];
Expand Down