Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suricata: init at 4.1.4 #64166

Merged
merged 1 commit into from
Jul 30, 2019
Merged

suricata: init at 4.1.4 #64166

merged 1 commit into from
Jul 30, 2019

Conversation

magenbluten
Copy link
Contributor

@magenbluten magenbluten commented Jul 2, 2019

this pull-request is based on #33886 but with both libprelude and old libnet dependencies removed.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 2, 2019
pkgs/applications/networking/ids/suricata/default.nix Outdated Show resolved Hide resolved
let

libmagic = file;
hyperscanSupport = stdenv.system == "x86_64-linux" || stdenv.system == "i686-linux";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hyperscanSupport = stdenv.system == "x86_64-linux" || stdenv.system == "i686-linux";
hyperscanSupport = stdenv.isLinux;

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because hyperscan is x86 only.

pkgs/applications/networking/ids/suricata/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/ids/suricata/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libnet/1.1.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libnet/1.1.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprelude/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprelude/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprelude/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libnet/1.1.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jul 7, 2019
@Lassulus
Copy link
Member

tested with nix-review and started it with the included configs and some test rules. Had to to change the log path from /var/log to something writable though

@Lassulus Lassulus merged commit 576c04a into NixOS:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants