Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TermReadKey: add workarounds for cross compilation #56019

Merged
merged 1 commit into from
Mar 12, 2019
Merged

perlPackages.TermReadKey: add workarounds for cross compilation #56019

merged 1 commit into from
Mar 12, 2019

Conversation

illegalprime
Copy link
Member

@illegalprime illegalprime commented Feb 18, 2019 •
edited
Loading

Motivation for this change

Allows this package to be cross-compiled, which is a dependency for many other more well-known packages (e.g. git).

Fixes #54510

One can test that these are now working:

nix build -f . pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey
nix build -f . pkgsCross.armv7l-hf-multiplatform.git
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer changed the base branch from master to staging February 19, 2019 01:29
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: vim 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 19, 2019
@matthewbauer matthewbauer changed the base branch from staging to master February 19, 2019 01:38
@matthewbauer matthewbauer changed the base branch from master to staging February 19, 2019 01:38
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: emacs Text editor 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: vim 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 19, 2019
@GrahamcOfBorg GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 19, 2019
@illegalprime
Copy link
Member Author

@volth any updates on this?

@matthewbauer matthewbauer merged commit 573a693 into NixOS:staging Mar 12, 2019
@illegalprime illegalprime mentioned this pull request Mar 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illegalprime @matthewbauer @GrahamcOfBorg