Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuxtyping: init at 1.8.3 #55490

Merged
merged 2 commits into from
Feb 16, 2019
Merged

tuxtyping: init at 1.8.3 #55490

merged 2 commits into from
Feb 16, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 9, 2019

Motivation for this change

I have a 5 year old. So why not.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 9, 2019
jtojnar
jtojnar requested changes Feb 9, 2019
View reviewed changes
pkgs/games/tuxtyping/default.nix Outdated Show resolved Hide resolved
pkgs/games/tuxtyping/default.nix Outdated Show resolved Hide resolved
@GrahamcOfBorg GrahamcOfBorg added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Feb 10, 2019
@aanderse aanderse changed the title tuxtyping: init at 1.8.0 tuxtyping: init at 1.8.3 Feb 15, 2019
@aanderse
Copy link
Member Author

@jtojnar please let me know if any other changes required.

jtojnar
jtojnar reviewed Feb 16, 2019
View reviewed changes
pkgs/games/t4kcommon/default.nix Outdated Show resolved Hide resolved
pkgs/games/t4kcommon/default.nix Outdated Show resolved Hide resolved
pkgs/games/t4kcommon/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member Author

@GrahamcOfBorg build tuxtype

@aanderse
Copy link
Member Author

I think that should do it...

@aanderse
Copy link
Member Author

@jtojnar merge request to fix configure.ac submitted as requested: https://salsa.debian.org/tux4kids-pkg-team/tuxtype/merge_requests/1

@jtojnar jtojnar merged commit dee617c into NixOS:master Feb 16, 2019
@jtojnar
Copy link
Member

jtojnar commented Feb 16, 2019

Looks good, thanks.

@aanderse aanderse deleted the tuxtyping branch February 16, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@jtojnar jtojnar jtojnar requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aanderse @jtojnar @symphorien @GrahamcOfBorg