Fetch spotify from snapcraft #44123

timokau · 2018-07-26T12:53:13Z

Motivation for this change

Spotify is currently fetched from a debian repository hosted on their own server. The big problem with that is that they only keep a couple of versions around. That leads to failures when trying to build older versions. Unfortunately we are not allowed to keep old versions and re-distribute them.

In december 2017, spotify released a "snap" package on snapcraft. That has the significant advantage that the server is not controlled by spotify and snapcraft does not automatically delete old versions and does not even allow spotify to remove them. The oldest version currently available on snapcraft is 1.0.59.395, while the oldest version available on the debian repository is 1.0.72.117.

Disadvantages of this approach

the snap contains all the dependencies at is ~160mb, while the debian package is ~90 mb. The installed versions have the same size.
the upgrade process is a bit more complex, since the snap url's are based on the snap_id (which doesn't change) and the revision. The revision takes the place of the version and is a simple increasing integer. It does not indicate weather or not the version is stable or what spotify version it responds to. Because of that I included update instructions and even a fully automated update script.
currently the versions on snapcraft and the debian repo don't quite match up. Snapcraft has 1.0.80.474, while the repository has 1.0.80.480. Both of these were released on the same day however and are probably pretty much identical. Who knows what that last version number signifies. Since the snap version is at least as "official" as the debian version, I assume that version is just as up-to-date.

Advantages of this approach

the spotify package doesn't break anymore

The advantages far outweight the disadvantages in my opinion. I've already been bitten by this at least twice. I wasn't able to rebuild my configuration anymore and had to remove spotify from my system packages.

Maintainers @edolstra @ftrvxmtrx @sheenobu @laMudri

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

timokau · 2018-07-26T12:55:18Z

This should also be picked into stable.

GrahamcOfBorg · 2018-07-26T13:08:10Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-26T13:08:17Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-26T13:08:41Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

dotlambda · 2018-08-01T15:04:05Z

pkgs/applications/audio/spotify/default.nix

+      grep 'version: ' meta/snap.yaml
+      echo "While the nix package specifies: ${version}."
+      echo "You probably chose the wrong revision or forgot to update the nix version."
+      #exit 1


Why is this commented out?

For debugging. Thanks for catching that, I fixed it.

GrahamcOfBorg · 2018-08-03T08:48:14Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-03T08:48:25Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

timokau · 2018-08-04T12:58:05Z

Lacking any objections, can somebody merge this?

7c6f434c · 2018-08-04T13:04:41Z

pkgs/applications/audio/spotify/default.nix

+    unsquashfs "$src" '/usr/share/spotify' '/usr/bin/spotify' '/meta/snap.yaml'
+    cd squashfs-root
+    if ! grep -q 'grade: stable' meta/snap.yaml; then
+      # Unfortunately this check is not relibale: At the moment (2018-07-26) the


«reliable»

Fixed, thanks.

The purpose of this update (or downgrade?) is to switch the spotify source to one more reliable. The current source only contains the last few releases, while the new source retains all old releases.

GrahamcOfBorg · 2018-08-04T13:32:07Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-04T13:32:25Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-04T13:32:26Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: spotify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

timokau force-pushed the spotify-snap branch from 0a23f12 to f62e797 Compare July 26, 2018 12:55

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 26, 2018

timokau mentioned this pull request Jul 29, 2018

[RFC 0029] Backports team NixOS/rfcs#29

Closed

3 tasks

dotlambda reviewed Aug 1, 2018

View reviewed changes

timokau force-pushed the spotify-snap branch from f62e797 to 1f5bcfa Compare August 3, 2018 08:36

7c6f434c reviewed Aug 4, 2018

View reviewed changes

spotify: 1.0.80.480.g51b03ac3-13 -> 1.0.80.474.gef6b503e-7

e875678

The purpose of this update (or downgrade?) is to switch the spotify source to one more reliable. The current source only contains the last few releases, while the new source retains all old releases.

timokau force-pushed the spotify-snap branch from 1f5bcfa to e875678 Compare August 4, 2018 13:18

7c6f434c merged commit d4893a7 into NixOS:master Aug 4, 2018

timokau deleted the spotify-snap branch August 4, 2018 14:10

timokau mentioned this pull request Jun 26, 2023

[Backport release-23.05] spotify: 1.2.9.743.g85d9593d -> 1.2.11.916.geb595a67 #238676

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fetch spotify from snapcraft #44123

Fetch spotify from snapcraft #44123

timokau commented Jul 26, 2018

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

dotlambda Aug 1, 2018

timokau Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

timokau commented Aug 4, 2018

7c6f434c Aug 4, 2018

timokau Aug 4, 2018

GrahamcOfBorg commented Aug 4, 2018

GrahamcOfBorg commented Aug 4, 2018

GrahamcOfBorg commented Aug 4, 2018

Fetch spotify from snapcraft #44123

Fetch spotify from snapcraft #44123

Conversation

timokau commented Jul 26, 2018

Motivation for this change

Disadvantages of this approach

Advantages of this approach

Things done

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

dotlambda Aug 1, 2018

Choose a reason for hiding this comment

timokau Aug 3, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

timokau commented Aug 4, 2018

7c6f434c Aug 4, 2018

Choose a reason for hiding this comment

timokau Aug 4, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Aug 4, 2018

GrahamcOfBorg commented Aug 4, 2018

GrahamcOfBorg commented Aug 4, 2018