-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s4cmd: init at 2.0.1 #43459
s4cmd: init at 2.0.1 #43459
Conversation
Tool for interacting with S3 buckets, with some performance optimizations over s3cmd. Skips installing the bash shell completion scripts in /etc, to work around: NixOS#4968 pypa/setuptools#130
@GrahamcOfBorg build s4cmd |
Success on x86_64-linux (full log) Attempted: s4cmd Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: s4cmd Partial log (click to expand)
|
@@ -0,0 +1,35 @@ | |||
{ stdenv, python3Packages }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh this application works and has support for both python2 and python3; should I set this as pythonPackages
and let it float to that alias, or should I advertise that it works with python3 as above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any point to running it under python2? It's fine as it is now imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key point is not what it runs now, but to show that it is compatible with both. This is/was important for the whole 2 to 3 migration. But, as that's not really happening I don't care much anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll leave it as python3Packages
then, since that very clearly shows it's compatible with python3, and is unlikely to have support dropped by upstream anytime soon.
Is there an issue/RFC/ticket/PR discussing some of the 2 to 3 migration plans/strategies/thoughts? Curious to learn more. Seems like we can just follow whatever upstream does for individual packages without having to take initiative ourselves.
Success on x86_64-linux (full log) Attempted: s4cmd Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: s4cmd Partial log (click to expand)
|
This one should be good to go |
Thanks! :) |
Tool for interacting with S3 buckets, with some performance optimizations over s3cmd.
Skips installing the bash shell completion scripts in /etc, to work around:
#4968
pypa/setuptools#130
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)