-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Agda builder, add documentation #39318
Conversation
The build process for Agda packages now mirrors that of Idris packages. There is an agdaWithPackages attribute that works like ghcWithPackages. This should make it easier to implement building Agda binaries, since that process can reuse agdaWithPackages.
cc: @Fuuzetsu @copumpkin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it removes the interactive part which is needed for nix-based Agda with emacs for example
@Fuuzetsu Can you point that part out to me? Is it the |
Yes precisely the passthru, being able to load stuff into emacs was actually the main motivation for original version of builder (not the one you're changing) |
@Fuuzetsu Can you describe the use-case in a little more detail? It seems to me like the user could use |
emacs needs to know where to find sources and compiled sources, it's not enough that agda binary sees it |
Does this break or improve the way we can package cedille? I didn't know there were any other agda binaries packaged in nixpkgs. |
Is there any reason the documentation and withPackages part of this can't be added without changing the agda mkderivation part? Otherwise I feel I'm missing something as I can't see how you can currently load any agda packages in emacs. |
@langston-barrett I believe this is now superseded by #76653. Shall we close? |
@turion Yes, agreed! 🎉 |
The build process for Agda packages now mirrors that of Idris packages. There is an
agda.withPackages
attribute that works likeghcWithPackages
.This should make it easier to implement building Agda binaries, since that process can reuse agdaWithPackages.
Motivation for this change
Fixes #19434
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)