Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamspeak5_client: 5.0.0-beta77 -> 6.0.0-beta2; teamspeak refactors #377748

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Jan 29, 2025

Fixes #376152

This is a continuation of #376274 and #376896 with some refactors of the teamspeak 3 client and server, and the teamspeak 6 client. Thanks @TheRealRobin and @iam-angel-val!

Release notes: https://community.teamspeak.com/t/teamspeak-6-0-0-beta1-screen-camera-sharing-communities-design-overhaul/54925

Some teamspeak packages had different licenses, or didn't include the distribution permit, so I created a top level license for it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@gepbird
Copy link
Contributor Author

gepbird commented Jan 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377748


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • nixpkgs-manual
  • teamspeak6-client

Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack license.

@gepbird
Copy link
Contributor Author

gepbird commented Feb 5, 2025

cc @drupol for reviewing #376274

@drupol
Copy link
Contributor

drupol commented Feb 5, 2025

cc @drupol for reviewing #376274

I usually don't review draft PR.

@gepbird
Copy link
Contributor Author

gepbird commented Feb 5, 2025

I usually don't review draft PR.

What I meant by reviewing is you requested some changes on that PR and left some comments, then you drafted it but it's not the point. Since that and this PR has the same topic, I thought you'd be interested to review this.

@drupol
Copy link
Contributor

drupol commented Feb 5, 2025

I'm OK to review THIS PR, but not the other one. Is that what you mean?

@gepbird
Copy link
Contributor Author

gepbird commented Feb 5, 2025

I'm OK to review THIS PR, but not the other one. Is that what you mean?

Yes. I only mentioned the other PR because it has the same topic and you already interacted with that. I wanted to make it clear why did I ping you.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM except a few nits. We should never re-use pname anywhere else. Please fix the suggestion I added and I'll merge this.

pkgs/by-name/te/teamspeak6-client/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/teamspeak6-client/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/teamspeak6-client/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/teamspeak6-client/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/teamspeak6-client/package.nix Outdated Show resolved Hide resolved
@gepbird gepbird force-pushed the teamspeak-6-client branch 2 times, most recently from 764c1db to 06f40db Compare February 5, 2025 21:35
@gepbird gepbird force-pushed the teamspeak-6-client branch from 06f40db to a8c8d69 Compare February 7, 2025 13:18
@gepbird
Copy link
Contributor Author

gepbird commented Feb 7, 2025

Fixed merge conflicts and added an update script

@drupol drupol merged commit 547acec into NixOS:master Feb 7, 2025
30 checks passed
@gepbird gepbird deleted the teamspeak-6-client branch February 8, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Request: teamspeak5_client 5.0.0-beta77 → 6.0.0-beta2
3 participants