-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamspeak5_client: 5.0.0-beta77 -> 6.0.0-beta2; teamspeak refactors #377748
Conversation
5529b9a
to
5c7eb15
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack license.
What I meant by reviewing is you requested some changes on that PR and left some comments, then you drafted it but it's not the point. Since that and this PR has the same topic, I thought you'd be interested to review this. |
I'm OK to review THIS PR, but not the other one. Is that what you mean? |
Yes. I only mentioned the other PR because it has the same topic and you already interacted with that. I wanted to make it clear why did I ping you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM except a few nits. We should never re-use pname
anywhere else. Please fix the suggestion I added and I'll merge this.
764c1db
to
06f40db
Compare
06f40db
to
a8c8d69
Compare
Fixed merge conflicts and added an update script |
Fixes #376152
This is a continuation of #376274 and #376896 with some refactors of the teamspeak 3 client and server, and the teamspeak 6 client. Thanks @TheRealRobin and @iam-angel-val!
Release notes: https://community.teamspeak.com/t/teamspeak-6-0-0-beta1-screen-camera-sharing-communities-design-overhaul/54925
Some teamspeak packages had different licenses, or didn't include the distribution permit, so I created a top level license for it.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.