-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3drive: init at 1.11.2 #376825
base: master
Are you sure you want to change the base?
s3drive: init at 1.11.2 #376825
Conversation
fe5a582
to
269f654
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't reformat licenses.nix in the same PR as adding a package.
@alyssais sorry! didn't notice my editor did that automatically, should be good now. |
|
You reformatted the licenses file again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not reformat files like this
sorry, finally took some time and disabled format on save |
maintainers = with maintainers; [ abueide ]; | ||
platforms = [ "x86_64-linux" ]; | ||
sourceProvenance = with sourceTypes; [ binaryNativeCode ]; | ||
mainProgram = finalAttrs.pname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone else will have to answer this definitively, but I doubt this is recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative LGTM. See above. Not sure.
|
s3drive is a remote storage client that allows interfacing via rclone and s3 to allow easy mounting, syncing and e2ee across many different storage providers. Provides a friendly client for linux, mac, windows, and android/ios.
https://s3drive.app/
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.