Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3drive: init at 1.11.2 #376825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

s3drive: init at 1.11.2 #376825

wants to merge 1 commit into from

Conversation

abueide
Copy link
Contributor

@abueide abueide commented Jan 25, 2025

s3drive is a remote storage client that allows interfacing via rclone and s3 to allow easy mounting, syncing and e2ee across many different storage providers. Provides a friendly client for linux, mac, windows, and android/ios.

https://s3drive.app/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jan 25, 2025
@nix-owners nix-owners bot requested a review from alyssais January 25, 2025 23:01
@abueide abueide force-pushed the s3drive branch 2 times, most recently from fe5a582 to 269f654 Compare January 26, 2025 00:07
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't reformat licenses.nix in the same PR as adding a package.

@abueide
Copy link
Contributor Author

abueide commented Jan 27, 2025

@alyssais sorry! didn't notice my editor did that automatically, should be good now.

lib/licenses.nix Outdated Show resolved Hide resolved
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376825


aarch64-darwin

✅ 2 packages built:
  • nix-init
  • nixpkgs-manual

@ethancedwards8
Copy link
Member

You reformatted the licenses file again

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not reformat files like this

@github-actions github-actions bot removed the 6.topic: lib The Nixpkgs function library label Feb 4, 2025
@abueide
Copy link
Contributor Author

abueide commented Feb 5, 2025

sorry, finally took some time and disabled format on save

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1-10 labels Feb 5, 2025
maintainers = with maintainers; [ abueide ];
platforms = [ "x86_64-linux" ];
sourceProvenance = with sourceTypes; [ binaryNativeCode ];
mainProgram = finalAttrs.pname;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone else will have to answer this definitively, but I doubt this is recommended

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative LGTM. See above. Not sure.

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376825


x86_64-linux

✅ 1 package built:
  • s3drive

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants