-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code-cursor: add aarch64-linux #373536
code-cursor: add aarch64-linux #373536
Conversation
@GaetanLepage I believe you have the ability to build aarch64-linux? If so, I welcome a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to see. I think this looks good.
Thank you. I just need to work out a few stylistic questions with Gaetan, who is reviewing. Edit: I think the main issue was he wanted to replace the table of two URLs with a single URL with a conditional part and a list of hashes. Unfortunately, it doesn't quite do what we want. |
18dfc27
to
3e0982c
Compare
I think that this is because Cursor's Download links for macOS has spaces in them, for whatever reason. Makes it really hard to find the hashes too. It could've been a single url, passing variables through the download link based on the OS, architecture, and version of the package which would simplify things further, but I couldn't figure out the %20's that are added in the url |
3e0982c
to
4ee4b0b
Compare
|
4ee4b0b
to
ae1c300
Compare
Changed the update script to be less sensitive to filename changes. It now extracts everything up to the architecture ID then constructs URLs for x86/arm64. This pattern will make Darwin support easier. |
@bet4it Please file a new bug and fill in the details there. Also, are you on a ARM linux box? If not, the issue isn't coming from this PR and we'll need to work on it separately. |
ae1c300
to
934768b
Compare
|
@sarahec I find this situation same on x86_64 and on previous version of code-cursor, so it's not related with this PR 🤔 |
Changes
update.sh
to collect new platformThis will facilitate adding Darwin in #373494
Tests
For reviewers
let
block) is so we can add Darwin installation easily. Darwin uses a different file format (.dmg disk images) and will need its own repack and install phases. We can assign these conditionally tosrc
andinstallPhase
based on platform class.