Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockstarlang: init at 2.0.29 #372755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pinage404
Copy link
Contributor

@pinage404 pinage404 commented Jan 10, 2025

Things done

Add a new package : rockstarlang

Rockstar is a computer programming language based on the lyrics to 1980s hard rock and power ballads.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pinage404 pinage404 marked this pull request as draft January 10, 2025 21:27
@pinage404
Copy link
Contributor Author

When executing the package

/nix/store/v64bkfnrnblnakg5mxnnlddxc6ypjjc9-rockstar-2.0.29/bin/rockstar

It fails with the following output

Process terminated. Couldn't find a valid ICU package installed on the system. Please install libicu (or icu-libs) using your package manager and try again. Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. Please see https://aka.ms/dotnet-missing-libicu for more information.
   at System.RuntimeExceptionHelpers.FailFast(String, Exception, String, RhFailFastReason, IntPtr, IntPtr) + 0x1e7
   at System.Globalization.GlobalizationMode.Settings..cctor() + 0xb7
   at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0xb3
   at System.Runtime.CompilerServices.ClassConstructorRunner.CheckStaticClassConstructionReturnNonGCStaticBase(StaticClassConstructionContext*, IntPtr) + 0x9
   at System.Globalization.CultureData.CreateCultureWithInvariantData() + 0x3e7
   at System.Globalization.CultureData.get_Invariant() + 0x16
   at System.Globalization.TextInfo..cctor() + 0x1c
   at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0xb3
   at System.Runtime.CompilerServices.ClassConstructorRunner.CheckStaticClassConstructionReturnGCStaticBase(StaticClassConstructionContext*, Object) + 0x9
   at System.Text.EncodingHelper.GetCharset() + 0x10d
   at System.Text.EncodingHelper.GetEncodingFromCharset() + 0x9
   at System.ConsolePal.GetConsoleEncoding() + 0x9
   at System.Console.get_OutputEncoding() + 0x41
   at System.Console.CreateOutputWriter(Stream) + 0x4a
   at System.Console.<get_Out>g__EnsureInitialized|26_0() + 0x3b
   at System.Console.WriteLine(String) + 0x10
   at Rockstar.Program.Main(String[] args) + 0x437
fish: Job 1, '/nix/store/v64bkfnrnblnakg5mxnn…' terminated by signal SIGABRT (Abandon)

In order to make it work, a DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 variable must be set

DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 /nix/store/v64bkfnrnblnakg5mxnnlddxc6ypjjc9-rockstar-2.0.29/bin/rockstar
Rockstar v2.0.29 on linux-x64.
Type 'exit' to exit.
» Shout "it works"
it works
« "it works"
» exit

I tried many things, i didn't find a better solution

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 10, 2025
@pinage404
Copy link
Contributor Author

pinage404 commented Jan 10, 2025

I also tried to build it from source pinage404/nixpkgs@rockstar...pinage404:nixpkgs:rockstar_built_from_source

The build fails with this message

nix build -L .#rockstarlang
rockstar> Running phase: unpackPhase
rockstar> unpacking source archive /nix/store/v22zb3wr1a1pzzcmp586v9d3yzakn76w-source
rockstar> source root is source
rockstar> Running phase: patchPhase
rockstar> Running phase: configureNuget
rockstar> ln: failed to create symbolic link '/build/nuget.NEFIcX/fallback/microsoft.net.illink.tasks/9.0.0': File exists

@pinage404
Copy link
Contributor Author

I need help

@pinage404 pinage404 changed the title rockstar: init at 2.0.29 rockstarlang: init at 2.0.29 Jan 11, 2025
@pinage404 pinage404 marked this pull request as ready for review January 15, 2025 23:18
@pinage404
Copy link
Contributor Author

i used makeWrapper to set the variable DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 in order to make it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant