-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: add S-K-Tiger #371782
base: master
Are you sure you want to change the base?
maintainers: add S-K-Tiger #371782
Conversation
[Nitpicking] |
Hi @S-K-Tiger, you don't need to create a separate pull request to add yourself to the maintainers list. In the comment you are referring to I just wanted to point out that adding yourself to the maintainers list and creating a new package should happen in two different commits (that can still be part of the same pull request). |
For some reason I had the positions of "commits" and "merge requests" the wrong way around in my previous comment. My apologies for the confusion. |
1a47903
to
8891ab1
Compare
8891ab1
to
69a173c
Compare
Failed to resolve the merge conflict without adding another commit or remaking the pull request. |
Attempting to remake pull request with resolved merge conflict. |
Things done
Added myself as a maintainer so I can add myself to the maintainers of the package I'm trying to make.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.