Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add S-K-Tiger #371782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

S-K-Tiger
Copy link

Things done

Added myself as a maintainer so I can add myself to the maintainers of the package I'm trying to make.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2025
@S-K-Tiger
Copy link
Author

[Nitpicking]
Reading a comment on a different issue #371774 (comment) it seems I incorrectly assumed that adding yourself as a maintainer and creating a new package had to be in 2 separate commits rather than 2 separate merge requests.

@Defelo
Copy link
Member

Defelo commented Jan 7, 2025

Hi @S-K-Tiger, you don't need to create a separate pull request to add yourself to the maintainers list. In the comment you are referring to I just wanted to point out that adding yourself to the maintainers list and creating a new package should happen in two different commits (that can still be part of the same pull request).

@S-K-Tiger
Copy link
Author

Hi @S-K-Tiger, you don't need to create a separate pull request to add yourself to the maintainers list. In the comment you are referring to I just wanted to point out that adding yourself to the maintainers list and creating a new package should happen in two different commits (that can still be part of the same pull request).

For some reason I had the positions of "commits" and "merge requests" the wrong way around in my previous comment.
It seems after my reading of the guidelines and requirements on how to properly contribute I ended up forgetting to proof read my own comments.

My apologies for the confusion.

@S-K-Tiger S-K-Tiger force-pushed the maintainers--add-S-K-Tiger branch from 1a47903 to 8891ab1 Compare January 17, 2025 16:47
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 17, 2025
@S-K-Tiger S-K-Tiger closed this Jan 17, 2025
@S-K-Tiger S-K-Tiger force-pushed the maintainers--add-S-K-Tiger branch from 8891ab1 to 69a173c Compare January 17, 2025 16:56
@S-K-Tiger
Copy link
Author

Failed to resolve the merge conflict without adding another commit or remaking the pull request.

@S-K-Tiger
Copy link
Author

Attempting to remake pull request with resolved merge conflict.

@S-K-Tiger S-K-Tiger reopened this Jan 17, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants