Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aegisub-arch1t3cht: init at feature_12 #370431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 3, 2025

Reintroduction of arch1t3cht's fork from #359027, until Aegisub absorbs all its features.

I'll create another PR to bump Aegisub to 3.4.1, see https://github.com/TypesettingTools/Aegisub/releases/tag/v3.4.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@emilazy
Copy link
Member

emilazy commented Jan 3, 2025

It seems best to just stick with one version of Aegisub for now, I think; I’d especially not want to see the expression forked like this.

I personally believe that we should just use arch1t3cht’s for now, since I don’t think the TypesettingTools version yet offers any compelling advantage over it; probably around 3.5.0 it would make sense to think about moving over as they integrate some of the feature work. But I think even just having the TypesettingTools version alone is preferable to having two separate packages.

@wegank
Copy link
Member Author

wegank commented Jan 3, 2025

One of my concerns is that arch1t3cht/Aegisub seems to be virtually frozen since a month ago, while TypesettingTools/Aegisub is actively receiving PRs. While Aegisub 3.4.1 doesn't bring any editing features that the other doesn't have, it certainly gains much better i18n support in at least two languages. I'd probably be less hesitant to switch to arch1t3cht's fork if the changes were backported...

@emilazy
Copy link
Member

emilazy commented Jan 3, 2025

Fair enough. I definitely think that moving to TypesettingTools as soon as they start to meaningfully catch up makes sense, and I wouldn’t expect arch1t3cht’s fork to have continued momentum at this point given the movement on that, but I am okay just sticking with the TypesettingTools status quo if it’s your preference. We packaged the dead wangqr fork for long enough that waiting a bit longer for functionality seems okay.

@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370431


x86_64-linux

✅ 1 package built:
  • aegisub-arch1t3cht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants