Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tpm2-pytss: fixup revision in tests #368426

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

baloo
Copy link
Member

@baloo baloo commented Dec 26, 2024

This fixes a regression introduced by #356063 in which libtpms now replies with a new revision.

This was fixed upstream in
tpm2-software/tpm2-pytss#593 but not available in a release yet.

Fixes #368402

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes a regression introduced by NixOS#356063
in which libtpms now replies with a new revision.

This was fixed upstream in
tpm2-software/tpm2-pytss#593 but not available
in a release yet.

Fixes NixOS#368402
@baloo
Copy link
Member Author

baloo commented Dec 26, 2024

cc @philiptaron

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 26, 2024
@baloo
Copy link
Member Author

baloo commented Dec 26, 2024

@ofborg build python312Packages.tpm2-pytss

@baloo baloo merged commit 308f45a into NixOS:master Dec 26, 2024
44 of 49 checks passed
@baloo baloo deleted the baloo/tpm2-pytss/fixup-revision branch December 26, 2024 23:15
@philiptaron
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.tpm2-pytss
2 participants