Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahoy: init at 2.2.0 #366784

Merged
merged 1 commit into from
Dec 24, 2024
Merged

ahoy: init at 2.2.0 #366784

merged 1 commit into from
Dec 24, 2024

Conversation

genga898
Copy link
Contributor

Closes #366503

Add ahoy to nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 20, 2024
@GaetanLepage
Copy link
Contributor

Have you try adding versionCheckHook and an updateScript ?

@genga898
Copy link
Contributor Author

genga898 commented Dec 24, 2024

Have you try adding versionCheckHook and an updateScript ?

The version flag has no output value, I skipped that, I will add the updateScript

ahoy: update meta

ahoy: add passthru script
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366784


x86_64-linux

✅ 1 package built:
  • ahoy

aarch64-linux

✅ 1 package built:
  • ahoy

x86_64-darwin

✅ 1 package built:
  • ahoy

aarch64-darwin

✅ 1 package built:
  • ahoy

@GaetanLepage GaetanLepage merged commit cf56aed into NixOS:master Dec 24, 2024
23 of 24 checks passed
@genga898 genga898 deleted the ahoy-init branch December 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: ahoy
2 participants