Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prisma,prisma-engines: 5.22.0 -> 6.0.1 #359944

Merged
merged 2 commits into from
Dec 7, 2024
Merged

prisma,prisma-engines: 5.22.0 -> 6.0.1 #359944

merged 2 commits into from
Dec 7, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 28, 2024 •
edited
Loading

  • prisma-engines: 5.22.0 -> 6.0.1
  • prisma: 5.22.0 -> 6.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 28, 2024
@aqrln aqrln added 8.has: package (update) This PR updates a package to a newer version 6.topic: rust 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 6.topic: nodejs and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 28, 2024
@aqrln
Copy link
Member Author

aqrln commented Nov 28, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

aarch64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 4 packages built:
  • documenso
  • pingvin-share.backend
  • prisma
  • prisma-engines

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog and removed 6.topic: rust 6.topic: nodejs labels Nov 28, 2024
@ofborg ofborg bot requested a review from tomhoule November 29, 2024 16:39
tomhoule
tomhoule approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@aqrln aqrln changed the title prisma,prisma-engines: 5.22.0 -> 6.0.0 prisma,prisma-engines: 5.22.0 -> 6.0.1 Dec 6, 2024
@aqrln
Copy link
Member Author

aqrln commented Dec 6, 2024

@Scrumplex @SuperSandro2000 I've addressed the feedback

@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 6, 2024
@ofborg ofborg bot requested a review from tomhoule December 7, 2024 12:07
@aqrln aqrln added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 7, 2024
@Scrumplex Scrumplex merged commit 1460b3e into NixOS:master Dec 7, 2024
41 of 42 checks passed
@aqrln aqrln deleted the prisma-6-0-0 branch December 10, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@tomhoule tomhoule tomhoule approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: rust 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aqrln @SuperSandro2000 @Scrumplex @tomhoule @wegank