Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri-mediaplayer-app: init at 1.1.0 #359708

Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Nov 27, 2024

Working towards #99090.

Lomiri Mediaplayer App is the video player app of the Lomiri DE.

I'm not sure if the test video setup in the VM test should be kept as-is - as a runCommand derivation built ahead-of-time, to have less things done during the test - or if it would be better to keep it generated on every run.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 27, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 28, 2024
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-mediaplayer-app branch from 07739d3 to 4fee12e Compare November 28, 2024 22:50
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-mediaplayer-app branch from 4fee12e to 00ee3ec Compare November 28, 2024 22:52
@OPNA2608 OPNA2608 marked this pull request as ready for review November 28, 2024 22:53
@h7x4 h7x4 added the 8.has: tests This PR has tests label Nov 29, 2024
@SuperSandro2000 SuperSandro2000 merged commit a4f09cb into NixOS:master Dec 6, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants