Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/eval: Minor fixes, ensure the correct commit is checked out #357965

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

infinisil
Copy link
Member

  • env.mergedSha is empty, so it checked out the master version by default
  • The process step used needs.attrs.outputs.mergedSha, but apparently that's empty unless attrs is declared as a needs, even though outputs implicitly depends on attrs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

- `env.mergedSha` is empty, so it checked out the master version by
default
- The process step used `needs.attrs.outputs.mergedSha`, but apparently
  that's empty unless `attrs` is declared as a `needs`, even though
  `outputs` implicitly depends on `attrs`
@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Nov 21, 2024
@Mic92 Mic92 merged commit 67d43ef into NixOS:master Nov 21, 2024
16 of 17 checks passed
@infinisil infinisil deleted the gha-eval-minor-fixes branch November 21, 2024 19:20
@azuwis
Copy link
Contributor

azuwis commented Nov 22, 2024

Actually actionlint found this:

.github/workflows/eval.yml:118:20: property "attrs" is not defined in object type {outpaths: {outputs: {}; result: string}} [expression]
    |
118 |           ref: ${{ needs.attrs.outputs.mergedSha }}
    |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

But i was not quite familiar with cross job variable passing, and ignored it.

Maybe we can add an actionlint workflow?

@Mic92
Copy link
Member

Mic92 commented Nov 22, 2024

#358087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants