porn-vault: init at 0.30.0-rc.11

[LuNeder]

Adds Porn-Vault and a NixOS Module for it.

This is my first ever nixpkgs PR, so while I did read the contributing guidelines I might have missed something. Please let me know if I need to change anything!

Some notes:

• I know the startup script is kinda cursed, but it's the cleanest way I was able to make it work with Nix. Please note that:
  • It reliably works and does not break other packages (and I've seen stuff way more cursed than this on nixpkgs lol)
  • If it was simple to patch PV into working without this, I'd make a PR upstream. Tho I have no node or javascript knowledge.
  • I talked to the PV dev on Discord and the next version of PV is planned to remove the need for izzy as well as probably allow setting a different tmp folder (instead of creating one on workdir, which is the reason the startup script is needed). When that arrives the startup script will be able to be removed, so honestly I think we can just leave this like this for now and once that version is released I'll make a new PR updating PV and removing the script if that's ok for y'all.

Also not a problem anymore. Thanks, Scrumplex!! ^-^

- I would love to compile Izzy from source instead of pulling a binary, but I can't get the rustPlatform thing to read the Cargo.toml I provide. It even entirely ignores me if I try to override buildPhase! If anyone can make this work, please let me know!!
- As I mentioned, izzy is to be deprecated and substituted by something inside PV itself on the next Porn-Vault version (no etas for that tho I think), so if compiling is too much work it might be worth it to just leave it pulling the binary for now until the next PV version is released. I was able to compile izzy from source now

Thanks!

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[LuNeder]

Fixed the formatting, sorry!

[justinas]

I would love to compile Izzy from source instead of pulling a binary, but I can't get the rustPlatform thing to read the Cargo.toml I provide.

Since the upstream does not provide a Cargo.lock, you'd need to generate it and commit it to nixpkgs, supplying it to the derivation via cargoLock.lockFile. nix-init seems to be able to generate a Cargo.lock by default.

The current situation is quite unfortunate, where PV is available for all platforms, but izzy is limited to x86_64-linux because of the prebuilt binary. Commiting a Cargo.lock would be preferred, I think.

[justinas]

Added some general notes on the approach. Not familiar with PV otherwise.

[LuNeder]

I would love to compile Izzy from source instead of pulling a binary, but I can't get the rustPlatform thing to read the Cargo.toml I provide.

Since the upstream does not provide a Cargo.lock, you'd need to generate it and commit it to nixpkgs, supplying it to the derivation via cargoLock.lockFile. nix-init seems to be able to generate a Cargo.lock by default.

The current situation is quite unfortunate, where PV is available for all platforms, but izzy is limited to x86_64-linux because of the prebuilt binary. Commiting a Cargo.lock would be preferred, I think.

I’ll try the lockFile thing, thanks!

[LuNeder]

I thiiink I’ve answered all of y’all suggestions either by replying or by changing the derivation now

[LuNeder]

I've attempted to add, on this latest force push, an option to manually specify the configFolder in case someone wanted to configure that separately. It mostly works, except when I specify a pqath in my home. Any other random path seems to work? Anyone knows why's that? I added ReadWritePaths = cfg.configFolder; which should have made that work I think?

[LuNeder]

Meh, not sure how useful that would be tbh? Maybe I should just remove that...

[LuNeder]

Apparently I fucked up making a merge commit instead of rebase, but I force pushed so it should have fixed it now?

[getchoo]

Everything else looks good!

[LuNeder]

Poor ofborg must be super overworked rn, he still hasn’t even started to test the push I added yesterday. Poor little thing.

[thiagokokada]

@ofborg eval

[github-actions]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] porn-vault: init at 0.30.0-rc.11 #357742