deltachat-desktop: 1.46.8 -> 1.48.0

[dotlambda]

Diff: deltachat/deltachat-desktop@v1.46.8...v1.48.0

Changelog: https://github.com/deltachat/deltachat-desktop/blob/v1.48.0/CHANGELOG.md

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[emilylange]

Hope this helps to get this going

[dotlambda]

@Simon-Laux Does this look like the correct alternative to DELTA_CHAT_RPC_SERVER?

[Simon-Laux]

yes. I first thought generating a @deltachat/stdio-rpc-server-<os>-<arch>/package.json might be necessary for detection, but looks like it already finds it just fine.

[dotlambda]

The Darwin build fails with

  • electron-builder  version=24.13.3 os=23.6.0
  • loaded configuration  file=/private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/packages/target-electron/electron-builder.json5
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=darwin arch=arm64 electron=32.2.2 appOutDir=dist/mac-arm64
  • copying Electron  source=/nix/store/6l7mmzg75dfz6hr581b0ygchaiwp6pjw-electron-32.2.2/Applications/Electron.app destination=/private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/packages/target-electron/dist/mac-arm64/Electron.app
  ⨯ open /private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/packages/target-electron/dist/mac-arm64/Electron.app/Contents/Frameworks/Electron Helper (GPU).app/Contents/Info.plist: permission denied  
  ⨯ /private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/node_modules/.pnpm/[email protected]/node_modules/app-builder-bin/mac/app-builder_arm64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1  failedTask=build stackTrace=Error: /private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/node_modules/.pnpm/[email protected]/node_modules/app-builder-bin/mac/app-builder_arm64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1
    at ChildProcess.<anonymous> (/private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/node_modules/.pnpm/[email protected]/node_modules/builder-util/src/util.ts:252:14)
    at Object.onceWrapper (node:events:634:26)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:305:5)
/private/tmp/nix-build-deltachat-desktop-1.48.0.drv-0/source/packages/target-electron:
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command failed with exit code 1: electron-builder --config ./electron-builder.json5 --dir -c.electronDist=/nix/store/6l7mmzg75dfz6hr581b0ygchaiwp6pjw-electron-32.2.2/Applications -c.electronVersion=32.2.2

Since I don't want to invest too much time into that I'll probably just mark it broken.

[nix-backports]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] deltachat-desktop: 1.46.8 -> 1.48.0 #361532