Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lanzaboote-stub: init at 0.3.0 #353052

Draft
wants to merge 7 commits into
base: staging
Choose a base branch
from

Conversation

baloo
Copy link
Member

@baloo baloo commented Nov 2, 2024

This is a rebase of the work done in #231951

This is split between two PRs:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@baloo baloo marked this pull request as draft November 2, 2024 04:01
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Nov 2, 2024
@baloo baloo mentioned this pull request Nov 2, 2024
13 tasks
@JohnRTitor JohnRTitor requested a review from K900 November 2, 2024 09:08
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@philiptaron
Copy link
Contributor

I'd love to review and merge this, @baloo. What's blocking it right now, other than the merge conflict in lib?

@baloo
Copy link
Member Author

baloo commented Dec 2, 2024

the uefi build does not work (see #353050) for a reason I'm not able to figure out. If you have any knowledge of the inner workings of clang/llvm, would love your help there

@baloo baloo force-pushed the baloo/lanzaboote-uefi-stub branch from 2dbd2f2 to ebe0c59 Compare December 2, 2024 18:57
@baloo
Copy link
Member Author

baloo commented Dec 2, 2024

Cleaned up the merge conflicts.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 3, 2024
@JohnRTitor
Copy link
Contributor

If you have any knowledge of the inner workings of clang/llvm

@NixOS/llvm or just @RossComputerGuy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants