Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.2.6 -> 2.3.0-rc2 #352111

Merged
merged 1 commit into from
Oct 31, 2024
Merged

zfsUnstable: 2.2.6 -> 2.3.0-rc2 #352111

merged 1 commit into from
Oct 31, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 29, 2024

Using this since rc1 on my systems.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92
Copy link
Member Author

Mic92 commented Oct 29, 2024

@MangoIV
Copy link
Contributor

MangoIV commented Oct 29, 2024

Would be nice to get this merged since the latest kernel version that is not EOL that you can use with NixOS and ZFS right now is 6.6.

@Mic92
Copy link
Member Author

Mic92 commented Oct 29, 2024

We usually also backport zfs updates anyway because of kernel churn.

@MangoIV
Copy link
Contributor

MangoIV commented Oct 29, 2024

I don't know if this is the correct place to ask ~ but why is it that the EOL kernel versions get "removed" while the kernel versions that use an old ZFS get marked as broken? It seems like weird UI for me to "suggest" a broken kernel to a user instead of staying on an EOL kernel for until the next stable kernel has zfs support again. It would be nice if I could add the old kernel to my allowed insecure packages instead of risking a broken system / having to roll back to an old kernel that caused me issues.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 29, 2024
@Mic92 Mic92 merged commit f600473 into NixOS:master Oct 31, 2024
41 checks passed
@Mic92 Mic92 deleted the zfs-bump branch October 31, 2024 07:10
@Mic92
Copy link
Member Author

Mic92 commented Oct 31, 2024

@ctheune had similar complaints about removing old k3s version, that a user also need to upgrade to the next version. I think the misconception that we have in nixpkgs w.r.t. security is that it's often considered a binary state (secure/insecure). However in practice security is a gradient / process that cannot be decided automatically and depends on the context. Something that would be an unacceptable security vulnerability for one person, is perfectly fine for another person that uses the software in a different context.

@ctheune
Copy link
Contributor

ctheune commented Oct 31, 2024

Right. If you take it to the extreme then we have to shut everything down to be "perfectly" secure. I fondly remember the security practices that become asinine and counter-productive even for their primary goals: where everyone keeps working against the security practices because nobody can get their job done (and go home on a Friday afternoon).

I'm adding this discussion to my list of examples where we can do better.

A big differentiator that I see is dealing with unstable and stable. Unstable can be more aggressive removing things but does need to take care to let people have a path forward from stable to stable+1.

@adamcstephens
Copy link
Contributor

I’m surprised this built without fixing the substitutions. Though it looks like no ofborg builds occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants