Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use overlayfs by default for netboot and iso #35188

Merged
merged 1 commit into from
Feb 5, 2020
Merged

use overlayfs by default for netboot and iso #35188

merged 1 commit into from
Feb 5, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Feb 19, 2018

Closes #32897

Motivation for this change

Faster nix store and less build (permission) failures such as NixOS/nix#1243 or #5829

Mount with this change outputs

overlay on /nix/store type overlay (rw,relatime,lowerdir=/mnt-root/nix/.ro-store,upperdir=/mnt-root/nix/.rw-store/store,workdir=/mnt-root/nix/.rw-store/work)

We also can't use just rw-store as upperdir and separate workdir due to overlayfs restrictions (this seems as only workable configuration).

cc @cleverca22 @dezgeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@makefu
Copy link
Contributor

makefu commented Feb 19, 2018

Does this PR fix the issue with going OOM when running a nixos-install with too many packages pre-configured?

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 19, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Feb 19, 2018

Does this PR fix the issue with going OOM when running a nixos-install with too many packages pre-configured?

No. That's hopefully fixed by #34636.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 19, 2018
@fpletz fpletz added this to the 18.03 milestone Feb 23, 2018
aij
aij reviewed Feb 27, 2018
View reviewed changes
Copy link
Contributor

@aij aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that even work with descriTPion?

nixos/modules/installer/netboot/netboot.nix Outdated Show resolved Hide resolved
nixos/modules/installer/cd-dvd/iso-image.nix Outdated Show resolved Hide resolved
@matthewbauer matthewbauer modified the milestones: 18.03, 18.09 Oct 1, 2018
@samueldr samueldr modified the milestones: 18.09, 19.03 Oct 6, 2018
@sorki sorki mentioned this pull request Jul 9, 2019
Closed
@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@matthewbauer matthewbauer modified the milestones: 19.03, 20.03 Aug 28, 2019
@misuzu
Copy link
Contributor

misuzu commented Feb 2, 2020

I'm just built an iso with this patch on top of a21c2fa and it is so much faster than regular iso!
I think this is ready for merge after rebase.

@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 4, 2020
@sorki
Copy link
Member Author

sorki commented Feb 4, 2020

Rebased with all comments addressed, tested manually and with boot.nix test.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/25

@infinisil
Copy link
Member

Other than that this looks great, tested on my mac without problems :)

infinisil
infinisil approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@infinisil infinisil merged commit 3ab846e into NixOS:master Feb 5, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 5, 2020
@infinisil @dtzWill
Merge pull request NixOS#35188 from sorki/overlayfs (DTZ: nouveau)
bc4b86e 
use overlayfs by default for netboot and iso

(cherry picked from commit 3ab846e)
ctheune added a commit to flyingcircusio/nixpkgs that referenced this pull request Aug 20, 2020
@ctheune
Include change from upstream PR to fix netboot unionfs issues
541d050 
NixOS#35188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg dezgeg left review comments

@Mic92 Mic92 Mic92 left review comments

@infinisil infinisil infinisil approved these changes

@aij aij aij approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

Switch install ISOs & netboot to overlayfs from unionfs-fuse