Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.lomiri-url-dispatcher: Split library into separate output #351228

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 25, 2024

... plus general maintenance and upstreaming our hack improvement, while I'm here.

Addresses one of the known issues in #260859, where libayatana-common pulls in outputs of Gtk, Qt, the Lomiri UI Toolkit, ... purely because of lomiri-url-dispatcher's GUI tools.

Before & after:

↪ nix --extra-experimental-features nix-command path-info -Sh /nix/store/m0v5h2ylvqjmhlwxk454r7vjzamrz428-libayatana-common-0.9.10
/nix/store/m0v5h2ylvqjmhlwxk454r7vjzamrz428-libayatana-common-0.9.10	 962.7M

↪ nix --extra-experimental-features nix-command path-info -Sh /nix/store/c2a66rxi6j1831mndip4n5vdzzcr3qi8-libayatana-common-0.9.10
/nix/store/c2a66rxi6j1831mndip4n5vdzzcr3qi8-libayatana-common-0.9.10	  63.2M

↪ nix --extra-experimental-features nix-command path-info -Shr /nix/store/c2a66rxi6j1831mndip4n5vdzzcr3qi8-libayatana-common-0.9.10
/nix/store/v2fdaykfy6ldp5wzn8hm2hb74nd35anw-xgcc-13.3.0-libgcc             	 147.4K
/nix/store/a0mbpky7hll3ljg1cnp5apc4y1bgb9hl-libunistring-1.2               	   1.8M
/nix/store/y9n3vjmh0iarg25ngv6bzbhbqam5rxch-libidn2-2.3.7                  	   2.2M
/nix/store/qii6jadf3xrhg4y0f5m09k11lh5ymwnv-glibc-2.40-36                  	  42.1M
/nix/store/z16jwhhg1pavcrjk5sfihjn6lnz93sfw-pcre2-10.44                    	  43.9M
/nix/store/cqli57dgmwfl40s690j640hdd4v5w9m0-libselinux-3.7                 	  45.4M
/nix/store/h887yq6z05ynslzqbqd125flw251j4hr-util-linux-minimal-2.39.4-lib  	  44.2M
/nix/store/raxk9vwg1raq7v90x27y4a0b0djfsi2v-libffi-3.4.6                   	  42.3M
/nix/store/rgsl4wpi5m4kql5gbqm3qrqbkm4kxr6q-zlib-1.3.1                     	  42.3M
/nix/store/cw9qz08zwd1li8vd8lm0laywa6rsi3gs-glib-2.80.4                    	  62.9M
/nix/store/1xwyvv9s8s5hn6j1fc3d155zxjl9sdm3-lomiri-url-dispatcher-0.1.3-lib	  63.0M
/nix/store/c2a66rxi6j1831mndip4n5vdzzcr3qi8-libayatana-common-0.9.10       	  63.2M

No more dependency on Qt & Lomiri outputs for any future consumers of the library. :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

To reduce the download closure of libayatana-common from 962.7M to 63.2M.
Not every libayatana-common user needs to install Lomiri now :)
@OPNA2608 OPNA2608 force-pushed the fix/lomiri-url-dispatcher-closure branch from 48894c6 to 4d3d768 Compare October 25, 2024 16:57
@OPNA2608 OPNA2608 changed the title lomiri.lomiri-url-dispatcher: Split library & i18n into separate output lomiri.lomiri-url-dispatcher: Split library into separate output Oct 25, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 25, 2024
@OPNA2608
Copy link
Contributor Author

Result of nixpkgs-review pr 351228 run on x86_64-linux 1

24 packages built:
  • ayatana-indicator-bluetooth
  • ayatana-indicator-datetime
  • ayatana-indicator-display
  • ayatana-indicator-power
  • ayatana-indicator-session
  • ayatana-indicator-sound
  • deltatouch
  • libayatana-common
  • lomiri.lomiri
  • lomiri.lomiri-indicator-network
  • lomiri.lomiri-indicator-network.dev
  • lomiri.lomiri-indicator-network.doc
  • lomiri.lomiri-push-qml
  • lomiri.lomiri-session
  • lomiri.lomiri-system-settings
  • lomiri.lomiri-system-settings-unwrapped
  • lomiri.lomiri-system-settings-unwrapped.dev
  • lomiri.lomiri-url-dispatcher
  • lomiri.lomiri-url-dispatcher.dev
  • lomiri.lomiri-url-dispatcher.lib
  • lomiri.qtmir
  • lomiri.qtmir.dev
  • lomiri.telephony-service
  • lomiri.teleports

@ofborg test lomiri ayatana-indicators lomiri-system-settings teleports

@OPNA2608 OPNA2608 merged commit 769a6a5 into NixOS:master Oct 31, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant